-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wifi_remote]: Make flat version structure across IDF releases #660
[wifi_remote]: Make flat version structure across IDF releases #660
Conversation
8852995
to
b0f8e88
Compare
@euripedesrocha @mantriyogesh PTAL at this proposal, I'd like to continue with linear versioning of wifi-remote (and replace #644 #643 with this one) still need to cleanup commit history and build related IDF examples. |
@@ -0,0 +1,432 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sense the directory stricture being modified and the esp_wifi_remote_weak.c moved inside of idf. Any changes from application/hosted side needed for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any changes from application/hosted side needed for this?
No change should be necessary, as the paths have been updated in CMake as well, so all headers are still available from public path (locations of sources shouldn't cause any trouble)
@@ -1,3 +1,4 @@ | |||
CONFIG_ESP_WIFI_REMOTE_LIBRARY_EPPP=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still wish to use eppp as default solution here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still keep eppp
as default for this example (since I wanted to build it with wifi capable chips as well, which doesn't seem to work with esp-hosted)
6e0e095
to
ab15807
Compare
LGTM.. |
rather than git history, as it might now work in GitHub CI (due to shallow cloning)
Rather than keeping sdkconfig.ci.*** for the smoke tests in git
Building also standard IDF examples that use esp-wifi-remote (building for wifiless targets ESP32P4, ESP32H2 and one wifi target ESP32s3)
IDF_VERSION_MAJOR, IDF_VERSION_MAJOR, rather than environmental variable {ESP_IDF_VERSION}
ab15807
to
c454ec0
Compare
Adds multiple IDF release branch support to a single version of
wifi-remote
to simplify release workflow of this componentesp_wifi_remote
is used